[MERGED] pysim[master]: utils: Fix documentation. 3+3=6 digits equals 3 bytes, not 6

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Alexander Chemeris gerrit-no-reply at lists.osmocom.org
Sat Jan 13 11:49:48 UTC 2018


Alexander Chemeris has submitted this change and it was merged.

Change subject: utils: Fix documentation. 3+3=6 digits equals 3 bytes, not 6
......................................................................


utils: Fix documentation. 3+3=6 digits equals 3 bytes, not 6

Change-Id: I2722d788a69976e1c64a9caf6cf3049af27f9a30
---
M pySim/utils.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Alexander Chemeris: Verified
  Harald Welte: Looks good to me, approved



diff --git a/pySim/utils.py b/pySim/utils.py
index 8463581..43d52dd 100644
--- a/pySim/utils.py
+++ b/pySim/utils.py
@@ -77,7 +77,7 @@
 	return swap_nibbles(rpad(iccid, 20))
 
 def enc_plmn(mcc, mnc):
-	"""Converts integer MCC/MNC into 6 bytes for EF"""
+	"""Converts integer MCC/MNC into 3 bytes for EF"""
 	return swap_nibbles(lpad('%d' % mcc, 3) + lpad('%d' % mnc, 3))
 
 def dec_spn(ef):

-- 
To view, visit https://gerrit.osmocom.org/5716
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2722d788a69976e1c64a9caf6cf3049af27f9a30
Gerrit-PatchSet: 1
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list