osmo-pcu[master]: Fix wrong encoding of LH bits

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 12 14:31:13 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/5686/1/src/encoding.cpp
File src/encoding.cpp:

Line 83: 		*write_index += 2;
why +2? I don't get it.  we are setting a single bit, aren't we?


-- 
To view, visit https://gerrit.osmocom.org/5686
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc6cb8e72219df55f359f130e509167d841f11bd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list