libosmocore[master]: gsm0480: expose the gsm0480_parse_ss_facility_ie()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 12 13:18:37 UTC 2018


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/3381/7/include/osmocom/gsm/gsm0480.h
File include/osmocom/gsm/gsm0480.h:

Line 73: int gsm0480_parse_ss_facility_ie(const uint8_t *facility_ie, uint16_t length,
the general "rule of thumb" in smocom coding style is is to follow "memcpy" notation, and have non-const output pointer first, followed by input arguments such as the const buffer.


-- 
To view, visit https://gerrit.osmocom.org/3381
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d3360f36c48eb1295610ab96ff264c45af77eb
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list