osmo-msc[master]: MSC: Intersect configured A5 algorithms with MS-supported ones

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 11 12:01:33 UTC 2018


Patch Set 2: Code-Review+1

(2 comments)

maybe fix that spec ref and merge

https://gerrit.osmocom.org/#/c/5560/2/src/libmsc/gsm_04_08.c
File src/libmsc/gsm_04_08.c:

Line 113: 		/* See 3GPP TS 24.008 10.5.1.7 */
cm 1 is 10.5.1.5


Line 124: 	case 2:
spec says for A5/2: "The MS shall set this bit to ‘0’.", might deserve a comment like above


-- 
To view, visit https://gerrit.osmocom.org/5560
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id124923ee52a357cb7d3e04d33f585214774f3a3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list