[MERGED] python/osmo-python-tests[master]: remove osmodumpdoc.py and osmotestconfig.py from py3 install

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jan 11 11:11:37 UTC 2018


Neels Hofmeyr has submitted this change and it was merged.

Change subject: remove osmodumpdoc.py and osmotestconfig.py from py3 install
......................................................................


remove osmodumpdoc.py and osmotestconfig.py from py3 install

Install these scripts as py2 only.

These scripts were added to py3 in error by commit "Improve python3
compatibility", I80e5850a8978d78cda793e2192ef4bd3fd54a121, which only addresses
print() compatibility but not encoding.

Recent patch Ief11b75acc973dc7aeaac9c2298a21dc5390efe4 removes osmotestvty.py
from py3 installation. osmodumpdoc.py and osmotestconfig.py are still py2 for
the same reasons and are also likely to fail when run as python3.

Related: OS#2821
Change-Id: Ibf8fc488ae2c022f75f0ca63483d80ed701e8c40
---
M setup.py
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/setup.py b/setup.py
index a91274d..bab9c38 100755
--- a/setup.py
+++ b/setup.py
@@ -23,9 +23,7 @@
 	scripts = ["scripts/osmodumpdoc.py",  "scripts/osmotestconfig.py",
 	           "scripts/osmotestvty.py"]
 elif sys.version_info.major == 3:
-	scripts = ["scripts/osmodumpdoc.py",
-                   "scripts/osmotestconfig.py",
-                   "scripts/osmo_interact_vty.py",
+	scripts = ["scripts/osmo_interact_vty.py",
 		   "scripts/osmo_interact_ctrl.py",
                    "scripts/osmo_ctrl.py",
 		   "scripts/soap.py",

-- 
To view, visit https://gerrit.osmocom.org/5693
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf8fc488ae2c022f75f0ca63483d80ed701e8c40
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list