[PATCH] libosmocore[master]: ussd_test.c: fix rc / len debug output confusion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Jan 10 17:46:26 UTC 2018


Review at  https://gerrit.osmocom.org/5744

ussd_test.c: fix rc / len debug output confusion

Both len and rc values were swapped in the test output.

Change-Id: Iebd82531c6ced5d16b15dad4ff4ce654c82db309
---
M tests/ussd/ussd_test.c
M tests/ussd/ussd_test.ok
2 files changed, 52 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/44/5744/1

diff --git a/tests/ussd/ussd_test.c b/tests/ussd/ussd_test.c
index e5a734f..cbc5857 100644
--- a/tests/ussd/ussd_test.c
+++ b/tests/ussd/ussd_test.c
@@ -140,13 +140,13 @@
 
 	for (i = size; i > sizeof(struct gsm48_hdr); --i) {
 		int rc = parse_ussd(&ussd_request[0], i);
-		printf("Result for %d is %d\n", rc, i);
+		printf("Result for len=%d is %d\n", i, rc);
 	}
 
 	printf("Mangling the container now\n");
 	for (i = size; i > sizeof(struct gsm48_hdr) + 2; --i) {
 		int rc = parse_mangle_ussd(&ussd_request[0], i);
-		printf("Result for %d is %d\n", rc, i);
+		printf("Result for len=%d is %d\n", i, rc);
 	}
 
 	printf("<CR> case test for 7 bit encode\n");
diff --git a/tests/ussd/ussd_test.ok b/tests/ussd/ussd_test.ok
index 69ea53c..aff383e 100644
--- a/tests/ussd/ussd_test.ok
+++ b/tests/ussd/ussd_test.ok
@@ -1,57 +1,57 @@
 Tested if it still works. Text was: **321#
 interrogateSS CFU text..'' code 33
 Testing parsing a USSD request and truncated versions
-Result for 1 is 28
-Result for 1 is 27
-Result for 1 is 26
-Result for 1 is 25
-Result for 0 is 24
-Result for 0 is 23
-Result for 0 is 22
-Result for 0 is 21
-Result for 0 is 20
-Result for 0 is 19
-Result for 0 is 18
-Result for 0 is 17
-Result for 0 is 16
-Result for 0 is 15
-Result for 0 is 14
-Result for 0 is 13
-Result for 0 is 12
-Result for 0 is 11
-Result for 0 is 10
-Result for 0 is 9
-Result for 0 is 8
-Result for 0 is 7
-Result for 0 is 6
-Result for 0 is 5
-Result for 0 is 4
-Result for 0 is 3
+Result for len=28 is 1
+Result for len=27 is 1
+Result for len=26 is 1
+Result for len=25 is 1
+Result for len=24 is 0
+Result for len=23 is 0
+Result for len=22 is 0
+Result for len=21 is 0
+Result for len=20 is 0
+Result for len=19 is 0
+Result for len=18 is 0
+Result for len=17 is 0
+Result for len=16 is 0
+Result for len=15 is 0
+Result for len=14 is 0
+Result for len=13 is 0
+Result for len=12 is 0
+Result for len=11 is 0
+Result for len=10 is 0
+Result for len=9 is 0
+Result for len=8 is 0
+Result for len=7 is 0
+Result for len=6 is 0
+Result for len=5 is 0
+Result for len=4 is 0
+Result for len=3 is 0
 Mangling the container now
-Result for 0 is 28
-Result for 0 is 27
-Result for 1 is 26
-Result for 1 is 25
-Result for 0 is 24
-Result for 0 is 23
-Result for 0 is 22
-Result for 0 is 21
-Result for 0 is 20
-Result for 0 is 19
-Result for 0 is 18
-Result for 0 is 17
-Result for 0 is 16
-Result for 0 is 15
-Result for 0 is 14
-Result for 0 is 13
-Result for 0 is 12
-Result for 0 is 11
-Result for 0 is 10
-Result for 0 is 9
-Result for 0 is 8
-Result for 0 is 7
-Result for 0 is 6
-Result for 1 is 5
+Result for len=28 is 0
+Result for len=27 is 0
+Result for len=26 is 1
+Result for len=25 is 1
+Result for len=24 is 0
+Result for len=23 is 0
+Result for len=22 is 0
+Result for len=21 is 0
+Result for len=20 is 0
+Result for len=19 is 0
+Result for len=18 is 0
+Result for len=17 is 0
+Result for len=16 is 0
+Result for len=15 is 0
+Result for len=14 is 0
+Result for len=13 is 0
+Result for len=12 is 0
+Result for len=11 is 0
+Result for len=10 is 0
+Result for len=9 is 0
+Result for len=8 is 0
+Result for len=7 is 0
+Result for len=6 is 0
+Result for len=5 is 1
 <CR> case test for 7 bit encode
 original = 30 31 32 33 34 35 36 37 
 encoded = b0 98 6c 46 ab d9 6e 

-- 
To view, visit https://gerrit.osmocom.org/5744
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebd82531c6ced5d16b15dad4ff4ce654c82db309
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list