This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgPatch Set 3: (1 comment) > (1 comment) https://gerrit.osmocom.org/#/c/5421/3/include/osmocom/codec/ecu.h File include/osmocom/codec/ecu.h: Line 9: uint8_t frame_backup[40]; > Still unsure about this. I just used the length which When I see this right, than this originally was struct ecu_fr_ctx I think your intension is to unify the struct, so that it can be used for all codecs. This would require to have the frame_backup[] as large as the larges possible frame - correct. However, I would still prefer to have a specific type for each ecu implementation because it may be that other ecu implementations work completely different and may require different kind of states. -- To view, visit https://gerrit.osmocom.org/5421 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a21f60db01bfe1c2b838f93866fad1d53fdcd1 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-HasComments: Yes