[PATCH] osmo-trx[master]: tests: Sockets: adapt to have reproducible output and enable...

[Pau Espin Pedrol]

Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5711

to look at the new patch set (#2).

tests: Sockets: adapt to have reproducible output and enable autotest

Change-Id: I5414076c6846b849973bcdeb3f2358b28dcb004c
---
M tests/CommonLibs/SocketsTest.cpp
A tests/CommonLibs/SocketsTest.ok
M tests/testsuite.at
3 files changed, 13 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/5711/2

diff --git a/tests/CommonLibs/SocketsTest.cpp b/tests/CommonLibs/SocketsTest.cpp
index 3198a5e..b51587d 100644
--- a/tests/CommonLibs/SocketsTest.cpp
+++ b/tests/CommonLibs/SocketsTest.cpp
@@ -44,7 +44,7 @@
 		char buf[MAX_UDP_LENGTH];
 		int count = readSocket.read(buf, MAX_UDP_LENGTH);
 		if (count>0) {
-			COUT("read: " << buf);
+			CERR("read: " << buf);
 			rc++;
 		} else {
 			sleep(2);
@@ -65,7 +65,7 @@
 		buf[MAX_UDP_LENGTH] =  '\0';
 		int count = readSocket.read(buf, MAX_UDP_LENGTH);
 		if (count>0) {
-			COUT("read: " << buf);
+			CERR("read: " << buf);
 			rc++;
 		} else {
 			sleep(2);
@@ -85,20 +85,22 @@
 
   UDPSocket socket1("127.0.0.1", 5061, "127.0.0.1", 5934);
   UDDSocket socket1U("testSource","testDestination");
-  
-  COUT("socket1: " << socket1.port());
+
+  CERR("socket1: " << socket1.port());
 
   // give the readers time to open
   sleep(1);
 
   for (int i=0; i<gNumToSend; i++) {
-    socket1.write("Hello IP land");	
+    socket1.write("Hello IP land");
 	socket1U.write("Hello Unix domain");
 	sleep(1);
   }
 
   readerThreadIP.join();
   readerThreadUnix.join();
+
+  printf("Done\n");
 }
 
 // vim: ts=4 sw=4
diff --git a/tests/CommonLibs/SocketsTest.ok b/tests/CommonLibs/SocketsTest.ok
new file mode 100644
index 0000000..a965a70
--- /dev/null
+++ b/tests/CommonLibs/SocketsTest.ok
@@ -0,0 +1 @@
+Done
diff --git a/tests/testsuite.at b/tests/testsuite.at
index f6b48af..00e6002 100644
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -26,11 +26,11 @@
 AT_CHECK([$abs_top_builddir/tests/CommonLibs/PRBSTest], [], [expout], [])
 AT_CLEANUP
 
-#AT_SETUP([SocketsTest])
-#AT_KEYWORDS([SocketsTest])
-#cat $abs_srcdir/CommonLibs/SocketsTest.ok > expout
-#AT_CHECK([$abs_top_builddir/tests/CommonLibs/SocketsTest], [], [expout], [])
-#AT_CLEANUP
+AT_SETUP([SocketsTest])
+AT_KEYWORDS([SocketsTest])
+cat $abs_srcdir/CommonLibs/SocketsTest.ok > expout
+AT_CHECK([$abs_top_builddir/tests/CommonLibs/SocketsTest], [], [expout], [ignore])
+AT_CLEANUP
 
 AT_SETUP([TimevalTest])
 AT_KEYWORDS([TimevalTest])

-- 
To view, visit https://gerrit.osmocom.org/5711
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5414076c6846b849973bcdeb3f2358b28dcb004c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder