osmo-ttcn3-hacks[master]: Fix f_enc_mcc_mnc() to return a properly encoded MCC/MNC tri...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jan 9 15:19:55 UTC 2018


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/5684/2/library/BSSMAP_Templates.ttcn
File library/BSSMAP_Templates.ttcn:

Line 651: 	return hex2oct(mcc[1] & mcc[0] & mnc[2] & mcc[2] & mnc[1] & mnc[0]);
> The incoming values are defined in BSC_Tests.ttcn as hex strings with the v
I think MNC should be '01'H instead. And then you can use the length of the hexstring (in number of nibbles) to know if it's a two-digit or threre-digig MNC.  Anyway, this could be a follow-up patch.


-- 
To view, visit https://gerrit.osmocom.org/5684
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99a5317e425d15acd463aa94c683676cacd54e0b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list