This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/5698/2/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: Line 348: lai.digits[0] = data[1 + i * sizeof(lai)]; this is a really ugly/verbose way of manually copying individual bytes. why is it needed? why not simply do a memcpy(&lai, data, sizeof(lai)) ? -- To view, visit https://gerrit.osmocom.org/5698 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3c62ff0fccea586794ea4b3c275a0685cc9326e Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes