[MERGED] osmo-bsc[master]: vty: fix OML link state printing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Jan 8 13:02:37 UTC 2018


Max has submitted this change and it was merged.

Change subject: vty: fix OML link state printing
......................................................................


vty: fix OML link state printing

Always print newline regardless of BTS uptime availability.

Change-Id: Ib80049fe66de17bc7acfbb774a30075f40a44dee
---
M src/libbsc/bsc_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/bsc_vty.c b/src/libbsc/bsc_vty.c
index 8281606..e60bdaf 100644
--- a/src/libbsc/bsc_vty.c
+++ b/src/libbsc/bsc_vty.c
@@ -298,9 +298,9 @@
 		vty_out(vty, "  OML Link state: %s", get_model_oml_status(bts));
 		sec = bts_uptime(bts);
 		if (sec)
-			vty_out(vty, " %llu days %llu hours %llu min. %llu sec.%s",
-				OSMO_SEC2DAY(sec), OSMO_SEC2HRS(sec), OSMO_SEC2MIN(sec), sec % 60,
-				VTY_NEWLINE);
+			vty_out(vty, " %llu days %llu hours %llu min. %llu sec.",
+				OSMO_SEC2DAY(sec), OSMO_SEC2HRS(sec), OSMO_SEC2MIN(sec), sec % 60);
+		vty_out(vty, "%s", VTY_NEWLINE);
 	} else {
 		vty_out(vty, "  E1 Signalling Link:%s", VTY_NEWLINE);
 		e1isl_dump_vty(vty, bts->oml_link);

-- 
To view, visit https://gerrit.osmocom.org/5660
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib80049fe66de17bc7acfbb774a30075f40a44dee
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list