[PATCH] libosmo-sccp[master]: error log: sccp_scoc.c: log failure to create conn_id

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5572

to look at the new patch set (#2).

error log: sccp_scoc.c: log failure to create conn_id

Tweak the FIXME to clarify that we're lacking a reply to the SCCP user besides
log output.

Change-Id: Ib235ff8e264aaf0c2e9794f464a3ba7b54816f3d
---
M src/sccp_scoc.c
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/72/5572/2

diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index e0742f9..12c733a 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -1623,7 +1623,9 @@
 		/* Allocate new connection structure */
 		conn = conn_create_id(inst, prim->u.connect.conn_id);
 		if (!conn) {
-			/* FIXME: inform user */
+			/* FIXME: inform SCCP user with proper reply */
+			LOGP(DLSCCP, LOGL_ERROR, "Cannot create conn-id for primitive %s\n",
+			     osmo_scu_prim_name(&prim->oph));
 			goto out;
 		}
 		conn->user = scu;
@@ -1635,7 +1637,8 @@
 		/* Resolve existing connection structure */
 		conn = conn_find_by_id(inst, scu_prim_conn_id(prim));
 		if (!conn) {
-			/* FIXME: inform user */
+			LOGP(DLSCCP, LOGL_ERROR, "Received unknown conn-id %u for primitive %s\n",
+			     scu_prim_conn_id(prim), osmo_scu_prim_name(&prim->oph));
 			goto out;
 		}
 		break;

-- 
To view, visit https://gerrit.osmocom.org/5572
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib235ff8e264aaf0c2e9794f464a3ba7b54816f3d
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>