osmo-msc[master]: mgcp: use osmo-mgw to switch rtp streams

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Jan 7 18:00:15 UTC 2018


Patch Set 18:

(3 comments)

updates from 34c3...

https://gerrit.osmocom.org/#/c/4980/18/src/libmsc/msc_mgcp.c
File src/libmsc/msc_mgcp.c:

Line 141: static void handle_error(struct mgcp_ctx *mgcp_ctx, enum msc_mgcp_cause_code cause)
on 34c3 I noticed that error logging doesn't convey the actual source of the error, so I added http://git.osmocom.org/osmo-msc/commit/?h=neels/34c3&id=f291d2f007f00f466b3c3299864b79997b13395d which logs file and line of the handle_error() caller


Line 929: 	OSMO_ASSERT(conn);
on 34c3 we apparently saw the need to add http://git.osmocom.org/osmo-msc/commit/?h=34c3&id=d251b5379c1c9309f37ab159275ad2e9694a6c38

an assert would crash the MSC, maybe that 34c3 patch would be better? not sure why conn==NULL would be hit though.


Line 953: 
on 34c3 we apparently saw the need for http://git.osmocom.org/osmo-msc/commit/?h=34c3&id=02dd4425a01b0fab069acfe3a2940d9e5e7fc085


-- 
To view, visit https://gerrit.osmocom.org/4980
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea9630358b3963261fa1993cf1f3b563ff23538
Gerrit-PatchSet: 18
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list