libosmocore[master]: Add function to properly encode RAI

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 5 12:49:23 UTC 2018


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/#/c/5652/2/include/osmocom/gsm/gsm48.h
File include/osmocom/gsm/gsm48.h:

Line 42: void gsm48_make_ra(struct gsm48_ra_id *out, const struct gprs_ra_id *raid);
gms48_encode_ra would fit better, IMHO


https://gerrit.osmocom.org/#/c/5652/2/src/gb/gprs_bssgp.c
File src/gb/gprs_bssgp.c:

PS2, Line 173: 6
guess we can now use sizeof(ra) ?


https://gerrit.osmocom.org/#/c/5652/2/src/gb/gprs_bssgp_bss.c
File src/gb/gprs_bssgp_bss.c:

PS2, Line 65:  6
guess we can now use sizeof(ra) ?


-- 
To view, visit https://gerrit.osmocom.org/5652
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list