osmo-bsc[master]: Support control connection status query for a particular MSC.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Jan 3 16:53:03 UTC 2018


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/5630/2/src/osmo-bsc/osmo_bsc_ctrl.c
File src/osmo-bsc/osmo_bsc_ctrl.c:

Line 75: 
It's better to use CTRL_CMD_DEFINE_RO to avoid boilerplate.


Line 90: static int msc_connection_status = 0; /* XXX unused */
If it's unused than why not remove it?


-- 
To view, visit https://gerrit.osmocom.org/5630
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd41474a1be80e782b19ec337c856b5efc593fa8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list