This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/5626 Fix llc_queue_size() type It either returns 0 or LLC queue size() which has size_t return type. This means it can never be negative - hence it's better to use size_t as return type. Change-Id: I2a6e849d349ab12854976bd0d68537a370a9c83d Fixes: CID181478 --- M src/tbf.cpp M src/tbf.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/26/5626/1 diff --git a/src/tbf.cpp b/src/tbf.cpp index aec67e7..9c1dac9 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -298,7 +298,7 @@ return m_ms ? m_ms->llc_queue() : NULL; } -int gprs_rlcmac_tbf::llc_queue_size() const +size_t gprs_rlcmac_tbf::llc_queue_size() const { /* m_ms->llc_queue() never returns NULL: GprsMs::m_llc_queue is a * member instance. */ diff --git a/src/tbf.h b/src/tbf.h index 40ed974..4a304af 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -228,7 +228,7 @@ uint8_t ms_class() const; void set_ms_class(uint8_t); GprsCodingScheme current_cs() const; - int llc_queue_size() const; + size_t llc_queue_size() const; time_t created_ts() const; uint8_t dl_slots() const; -- To view, visit https://gerrit.osmocom.org/5626 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a6e849d349ab12854976bd0d68537a370a9c83d Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de>