[MERGED] osmo-bts[master]: pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 28 22:21:24 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot
......................................................................


pcu_sock: LOG + drop DATA.req from PCU for non-PDCH timeslot

Change-Id: I3ae496eca96bc0823dfeca16ce36c200ce000895
---
M src/common/pcu_sock.c
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c
index 0d1f07a..cd8e0b2 100644
--- a/src/common/pcu_sock.c
+++ b/src/common/pcu_sock.c
@@ -528,6 +528,12 @@
 			break;
 		}
 		ts = &trx->ts[data_req->ts_nr];
+		if (!ts_should_be_pdch(ts)) {
+			LOGP(DPCU, LOGL_ERROR, "%s: Received PCU DATA request for non-PDCH TS\n",
+				gsm_ts_name(ts));
+			rc = -EINVAL;
+			break;
+		}
 		is_ptcch = (data_req->sapi == PCU_IF_SAPI_PTCCH);
 		rc = l1sap_pdch_req(ts, is_ptcch, data_req->fn, data_req->arfcn,
 			data_req->block_nr, data_req->data, data_req->len);

-- 
To view, visit https://gerrit.osmocom.org/7007
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ae496eca96bc0823dfeca16ce36c200ce000895
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list