This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: bsc_api: drop unknown RR messages. ...................................................................... bsc_api: drop unknown RR messages. Radio Resource (RR) handling is entirely done inside the BSC. However, the current implementation forwards unknown RR messages to the MSC. This is not compliant to the specification. - Remove the forwarding and drop any unknown RR message. Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae --- M src/libbsc/bsc_api.c 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c index 2dc7b9a..7c9ed6f 100644 --- a/src/libbsc/bsc_api.c +++ b/src/libbsc/bsc_api.c @@ -773,14 +773,10 @@ api->dtap(conn, link_id, msg); break; default: - /* Normally, a MSC should never receive RR - * messages, but we'd rather forward what we - * don't know than drop it... */ + /* Drop unknown RR message */ LOGP(DRR, LOGL_NOTICE, - "BSC: Passing %s 04.08 RR message to MSC\n", - gsm48_rr_msg_name(msg_type)); - if (api->dtap) - api->dtap(conn, link_id, msg); + "%s Dropping %s 04.08 RR message from %s\n", + gsm_lchan_name(conn->lchan), gsm48_rr_msg_name(msg_type)); } break; default: -- To view, visit https://gerrit.osmocom.org/6861 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a4d311f6939a4fcee59129daa18da4a2ab510ae Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder