This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6947
to look at the new patch set (#2).
msc_mgcp: Add FSM event names
The FSM (fsm_msc_mgcp) lacks a proper definition of the FSM event
names. This causes problems when inspecting the FSM using the VTY.
- Add proper FSM Event names
Closes: OS#2924
Change-Id: I6823756a63b08a71e5518130e49751aa073dbcd2
---
M src/libmsc/msc_mgcp.c
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/47/6947/2
diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c
index 2bc186e..3ac30c4 100644
--- a/src/libmsc/msc_mgcp.c
+++ b/src/libmsc/msc_mgcp.c
@@ -134,6 +134,18 @@
EV_DLCX_ALL_RESP,
};
+static const struct value_string msc_mgcp_fsm_evt_names[] = {
+ OSMO_VALUE_STRING(EV_INIT),
+ OSMO_VALUE_STRING(EV_ASSIGN),
+ OSMO_VALUE_STRING(EV_CONNECT),
+ OSMO_VALUE_STRING(EV_TEARDOWN),
+ OSMO_VALUE_STRING(EV_TEARDOWN_ERROR),
+ OSMO_VALUE_STRING(EV_CRCX_RAN_RESP),
+ OSMO_VALUE_STRING(EV_CRCX_CN_RESP),
+ OSMO_VALUE_STRING(EV_DLCX_ALL_RESP),
+ {0, NULL}
+};
+
/* A general error handler function. On error we still have an interest to
* remove a half open connection (if possible). This function will execute
* a controlled jump to the DLCX phase. From there, the FSM will then just
@@ -860,6 +872,7 @@
.num_states = ARRAY_SIZE(fsm_msc_mgcp_states),
.log_subsys = DMGCP,
.timer_cb = fsm_timeout_cb,
+ .event_names = msc_mgcp_fsm_evt_names,
};
/* Notify that a new call begins. This will create a connection for the
--
To view, visit https://gerrit.osmocom.org/6947
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6823756a63b08a71e5518130e49751aa073dbcd2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder