osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Feb 26 01:42:07 UTC 2018


Patch Set 1:

> > Why? are you planning to install the qemu-img in there? Easier
 > than
 > > /opt for permission-related reasons?
 > 
 > IMHO: A jenkins job shouldn't do anything outside it's own working
 > directory. I know this is sometimes hard. Using $HOME/qemu-img is
 > still not optimal, but at least it doesn't require a directory to
 > be created by root with special owner/group..

I was not counting on creating the qemu-arm enviornment during usual jenkins job run, but now that we move to a more automatised way to create jenkins node it must happen and it's fine for me. Since I was expecting the qemu-arm to be already there  (manually set up), then the env was used mostly read-only, so no issue. But now that we are creating it, it's fine moving it to $HOME.

A better way would perhaps be creating it inside $OWRKSPACE. I think the clean_worksapce script has some way to set a blacklist to not clean that specific directory inside WORKSPACE. If it's not there, could be a nice addition, but for now using $HOME seems good if it takes a lot of time to add this feature.

-- 
To view, visit https://gerrit.osmocom.org/6909
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56f314d78c0ca968b1fef9a91ecd540a7cc8fa86
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: No



More information about the gerrit-log mailing list