libosmocore[master]: implement support for 3-digit MNC with leading zeros

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Feb 25 13:29:07 UTC 2018


Patch Set 4:

I think it would make sense to introuce a new 'struct gsm_mcc' or the like to encapsulate the uint16_t + bool flag and then use that as function argument rather than always having a mnc _and_ a 'bool thre_digits' argument.

Or even start to treat the MNC as a string in the libosmo* API? The [NUL terminated] string carries length information with it implicitly. Or something like a 'char[4]' which has space for 2/3-digit MNC plus terminating NUL?

I mean, as we're breaking the API/ABI anyway, we can mals ake it comfortable for the API user, not harder.

-- 
To view, visit https://gerrit.osmocom.org/6659
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list