[PATCH] osmo-ttcn3-hacks[master]: RSL: Make ts_RSL_IPA_DLCX require a conn_id value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Feb 25 11:50:49 UTC 2018


Review at  https://gerrit.osmocom.org/6894

RSL: Make ts_RSL_IPA_DLCX require a conn_id value

The way how TTCN-3 templates work it's not possible for us to have
a parametric template for both generating DLCX with conn_id and without :(

Change-Id: Icb772ca5b9661ab39b1c161fa4ebc70544275d8f
---
M library/RSL_Types.ttcn
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/6894/1

diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn
index 336b042..1d68969 100644
--- a/library/RSL_Types.ttcn
+++ b/library/RSL_Types.ttcn
@@ -1453,13 +1453,12 @@
 		}
 	}
 
-	template RSL_Message ts_RSL_IPA_DLCX(RslChannelNr chan_nr,
-					     template (omit) uint16_t ipa_conn_id := omit) := {
+	template RSL_Message ts_RSL_IPA_DLCX(RslChannelNr chan_nr, uint16_t ipa_conn_id) := {
 		msg_disc := ts_RSL_MsgDisc(RSL_MDISC_IPACCESS, false),
 		msg_type := RSL_MT_IPAC_DLCX,
 		ies := {
-			t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr})
-			/* FIXME: optional conn_id */
+			t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}),
+			t_RSL_IE(RSL_IE_IPAC_CONN_ID, RSL_IE_Body:{ipa_conn_id := ipa_conn_id})
 		}
 	}
 	template RSL_Message tr_RSL_IPA_DLCX(template RslChannelNr chan_nr,

-- 
To view, visit https://gerrit.osmocom.org/6894
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb772ca5b9661ab39b1c161fa4ebc70544275d8f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list