[PATCH] osmocom-bb[master]: trxcon/scheduler: deactivate lchans when resetting / deletin...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 22 15:33:36 UTC 2018


Review at  https://gerrit.osmocom.org/6816

trxcon/scheduler: deactivate lchans when resetting / deleting TS

Previously, when resetting or deleting a timeslot, we did not
deactivate the logical channels, relaying on talloc hierarchical
nature. This approach may cause some problems, e.g. on embedded
systems with emulated talloc API.

Change-Id: I8c34c793df87bd8c79b7bf1f05b949faf10520e8
---
M src/host/trxcon/sched_trx.c
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/6816/1

diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c
index 2142119..9567844 100644
--- a/src/host/trxcon/sched_trx.c
+++ b/src/host/trxcon/sched_trx.c
@@ -194,6 +194,12 @@
 
 	LOGP(DSCH, LOGL_NOTICE, "Delete TDMA timeslot #%u\n", tn);
 
+	/* Deactivate all logical channels */
+	sched_trx_deactivate_all_lchans(ts);
+
+	/* Free channel states */
+	talloc_free(ts->lchans);
+
 	/* Flush queue primitives for TX */
 	sched_prim_flush_queue(&ts->tx_prims);
 
@@ -284,6 +290,9 @@
 	/* Flush queue primitives for TX */
 	sched_prim_flush_queue(&ts->tx_prims);
 
+	/* Deactivate all logical channels */
+	sched_trx_deactivate_all_lchans(ts);
+
 	/* Free channel states */
 	talloc_free(ts->lchans);
 

-- 
To view, visit https://gerrit.osmocom.org/6816
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c34c793df87bd8c79b7bf1f05b949faf10520e8
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list