[PATCH] osmocom-bb[master]: host/trxcon/scheduler: ignore incomplete sets of bursts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 22 15:33:16 UTC 2018


Review at  https://gerrit.osmocom.org/6758

host/trxcon/scheduler: ignore incomplete sets of bursts

To be able to decode one xCCH message, it's required to have
all set of bursts collected (4/4). Otherwise we should not
even try to decode an incomplete set.

Change-Id: Iaa63462efe19b8e96102fc8c8d8c968a2df2c70e
---
M src/host/trxcon/sched_lchan_xcch.c
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/6758/1

diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c
index 12bb6ee..81bd305 100644
--- a/src/host/trxcon/sched_lchan_xcch.c
+++ b/src/host/trxcon/sched_lchan_xcch.c
@@ -149,13 +149,7 @@
 			ts->mf_layout->period,
 			trx_lchan_desc[chan].name);
 
-		/* We require first burst to have correct FN */
-		if (!(*mask & 0x1)) {
-			*mask = 0x0;
-			return 0;
-		}
-
-		/* FIXME: return from here? */
+		return -1;
 	}
 
 	/* Attempt to decode */

-- 
To view, visit https://gerrit.osmocom.org/6758
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa63462efe19b8e96102fc8c8d8c968a2df2c70e
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list