[PATCH] osmocom-bb[master]: host/trxcon/l1ctl.c: handle L1CTL_PM_REQ correctly

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 22 15:32:58 UTC 2018


Review at  https://gerrit.osmocom.org/6724

host/trxcon/l1ctl.c: handle L1CTL_PM_REQ correctly

Change-Id: Ib5a2198f21e747b6169ef141817ef22b241ef9fa
---
M src/host/trxcon/l1ctl.c
1 file changed, 3 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/24/6724/1

diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c
index da69e86..d5c3b57 100644
--- a/src/host/trxcon/l1ctl.c
+++ b/src/host/trxcon/l1ctl.c
@@ -245,7 +245,7 @@
 
 static int l1ctl_rx_pm_req(struct l1ctl_link *l1l, struct msgb *msg)
 {
-	uint16_t arfcn_start, arfcn_stop, arfcn;
+	uint16_t arfcn_start, arfcn_stop;
 	struct l1ctl_pm_req *pmr;
 	int rc = 0;
 
@@ -265,18 +265,8 @@
 		arfcn_start &~ ARFCN_FLAG_MASK,
 		arfcn_stop &~ ARFCN_FLAG_MASK);
 
-	/**
-	 * HACK: power measurement isn't implemented yet,
-	 * sending fake results for now...
-	 *
-	 * FIXME: l1ctl_link.c:203 Failed to enqueue msg!
-	 * l1l->wq size is limited to 100, so we cannot
-	 * put more messages until osmo_select_main()
-	 * is called.
-	 */
-	for (arfcn = arfcn_start; arfcn <= arfcn_stop; arfcn++)
-		l1ctl_tx_pm_conf(l1l, arfcn, arfcn == 33 ?
-			-60 : -120, arfcn == arfcn_stop);
+	/* Send measurement request to transceiver */
+	rc = trx_if_cmd_measure(l1l->trx, arfcn_start, arfcn_stop);
 
 exit:
 	msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/6724
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5a2198f21e747b6169ef141817ef22b241ef9fa
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list