This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: gsm0408_test: cosmetically re-order MCC to come before MNC ...................................................................... gsm0408_test: cosmetically re-order MCC to come before MNC For consistency in human readability, MCC simply should come first, always. Change-Id: Idb86a7088fac4d8a8c41190ab46f9801635f4eee --- M tests/gsm0408/gsm0408_test.c M tests/gsm0408/gsm0408_test.ok 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 8e6cf2f..87f8dde 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -132,7 +132,7 @@ static inline void dump_ra(const struct gprs_ra_id *raid) { - printf("RA: MNC=%u, MCC=%u, LAC=%u, RAC=%u\n", raid->mnc, raid->mcc, raid->lac, raid->rac); + printf("RA: MCC=%u, MNC=%u, LAC=%u, RAC=%u\n", raid->mcc, raid->mnc, raid->lac, raid->rac); } static inline void check_ra(const struct gprs_ra_id *raid) @@ -160,14 +160,14 @@ static struct gprs_ra_id test_ra_cap_items[] = { { - .mnc = 121, .mcc = 77, + .mnc = 121, .lac = 666, .rac = 5, }, { - .mnc = 98, .mcc = 84, + .mnc = 98, .lac = 11, .rac = 89, }, diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok index 76a7940..295d8ec 100644 --- a/tests/gsm0408/gsm0408_test.ok +++ b/tests/gsm0408/gsm0408_test.ok @@ -3,10 +3,10 @@ Simple TMSI encoding test....passed Simple IMSI encoding test....passed: [10] 17 08 99 10 07 00 00 00 64 02 Constructed RA: -RA: MNC=121, MCC=77, LAC=666, RAC=5 -RA: MNC=121, MCC=77, LAC=666, RAC=5 +RA: MCC=77, MNC=121, LAC=666, RAC=5 +RA: MCC=77, MNC=121, LAC=666, RAC=5 RA test...passed Constructed RA: -RA: MNC=98, MCC=84, LAC=11, RAC=89 -RA: MNC=98, MCC=84, LAC=11, RAC=89 +RA: MCC=84, MNC=98, LAC=11, RAC=89 +RA: MCC=84, MNC=98, LAC=11, RAC=89 RA test...passed -- To view, visit https://gerrit.osmocom.org/6655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb86a7088fac4d8a8c41190ab46f9801635f4eee Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder