[MERGED] osmo-bsc[master]: chan_compat_with_mode: signalling works over all channel types

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: chan_compat_with_mode: signalling works over all channel types
......................................................................


chan_compat_with_mode: signalling works over all channel types

chan_compat_with_mode() currently only considered the requirements of
voice/csd services.  It failed to realize that GSM48_CMODE_SIGN
can also be performed over a SDCCH, resulting in unneeded channel
allocation/assignment to TCH type channels, e.g. for SMS.

This makes TC_assignment_sign pass.

Change-Id: I85ffcbd32ccd2617c897edb3b904f56bacd0684f
Closes: OS#2762
---
M src/libbsc/bsc_api.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libbsc/bsc_api.c b/src/libbsc/bsc_api.c
index 9086719..5f45218 100644
--- a/src/libbsc/bsc_api.c
+++ b/src/libbsc/bsc_api.c
@@ -419,6 +419,13 @@
 {
 	switch (chan_mode) {
 	case GSM48_CMODE_SIGN:
+		switch (lchan->type) {
+		case GSM_LCHAN_TCH_F:
+		case GSM_LCHAN_TCH_H:
+		case GSM_LCHAN_SDCCH:
+			return 1;
+		}
+		break;
 	case GSM48_CMODE_SPEECH_V1:
 	case GSM48_CMODE_SPEECH_AMR:
 	case GSM48_CMODE_DATA_3k6:

-- 
To view, visit https://gerrit.osmocom.org/6592
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I85ffcbd32ccd2617c897edb3b904f56bacd0684f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder