[MERGED] osmocom-bb[sylvain/testing]: transceiver: Fix RSP SETSLOT format

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 19 09:06:11 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: transceiver: Fix RSP SETSLOT format
......................................................................


transceiver: Fix RSP SETSLOT format

According to osmo-trx README:
SETSLOT sets the format of the uplink timeslots in the ARFCN.
The <timeslot> indicates the timeslot of interest.
The <chantype> indicates the type of channel that occupies the timeslot.
A chantype of zero indicates the timeslot is off.
CMD SETSLOT <timeslot> <chantype>
RSP SETSLOT <status> <timeslot> <chantype>

Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4
Related: OS#2944
---
M src/host/layer23/src/transceiver/trx.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/src/host/layer23/src/transceiver/trx.c b/src/host/layer23/src/transceiver/trx.c
index 9149b7c..24cc8d9 100644
--- a/src/host/layer23/src/transceiver/trx.c
+++ b/src/host/layer23/src/transceiver/trx.c
@@ -307,7 +307,7 @@
 	if ((n != 2) || (tn < 0) || (tn > 7) || (type < 0) || (type > 8))
 		return _trx_ctrl_send_resp(trx, cmd, "%d %d %d", -1, tn, type);
 
-	return _trx_ctrl_send_resp(trx, cmd, "%d %d", 0, type);
+	return _trx_ctrl_send_resp(trx, cmd, "%d %d %d", 0, tn, type);
 }
 
 static int

-- 
To view, visit https://gerrit.osmocom.org/6457
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: sylvain/testing
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list