[MERGED] osmocom-bb[jolly/testing]: transceiver: Fix RSP SETSLOT format

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 19 09:05:41 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: transceiver: Fix RSP SETSLOT format
......................................................................


transceiver: Fix RSP SETSLOT format

According to osmo-trx README:
SETSLOT sets the format of the uplink timeslots in the ARFCN.
The <timeslot> indicates the timeslot of interest.
The <chantype> indicates the type of channel that occupies the timeslot.
A chantype of zero indicates the timeslot is off.
CMD SETSLOT <timeslot> <chantype>
RSP SETSLOT <status> <timeslot> <chantype>

Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4
Related: OS#2944
---
M src/host/layer23/src/transceiver/trx.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve; Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/layer23/src/transceiver/trx.c b/src/host/layer23/src/transceiver/trx.c
index 8432dca..3f51928 100644
--- a/src/host/layer23/src/transceiver/trx.c
+++ b/src/host/layer23/src/transceiver/trx.c
@@ -340,7 +340,7 @@
 	if (trx->l1l[tn])
 		l1ctl_tx_bts_mode(trx->l1l[tn], 1, trx->type, trx->bsic, trx->arfcn, trx->gain, trx->l1l[tn]->tx_mask, trx->l1l[tn]->rx_mask, trx->handover);
 
-	return _trx_ctrl_send_resp(trx, cmd, "%d %d", 0, type);
+	return _trx_ctrl_send_resp(trx, cmd, "%d %d %d", 0, tn, type);
 }
 
 static int

-- 
To view, visit https://gerrit.osmocom.org/6449
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: jolly/testing
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: roox <mardnh at gmx.de>



More information about the gerrit-log mailing list