[MERGED] osmo-pcu[master]: Use explicit type for pcu_lsb()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Feb 19 08:33:04 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: Use explicit type for pcu_lsb()
......................................................................


Use explicit type for pcu_lsb()

It's only used for byte-long input so we can specify input and output
types explicitly.

Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a
---
M src/pcu_utils.h
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/pcu_utils.h b/src/pcu_utils.h
index 767771c..3292452 100644
--- a/src/pcu_utils.h
+++ b/src/pcu_utils.h
@@ -44,8 +44,7 @@
 	return count;
 }
 
-template <typename T>
-inline T pcu_lsb(T x)
+inline uint8_t pcu_lsb(uint8_t x)
 {
 	return x & -x;
 }

-- 
To view, visit https://gerrit.osmocom.org/6105
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0bef691e17e4331c7c4b491661e36173d85388a
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>



More information about the gerrit-log mailing list