libosmocore[master]: utils: add osmo-gsmtap-sink, simplistic UDP receiver

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Feb 17 14:58:17 UTC 2018


Patch Set 1:

> it just opens a port to receive the gsmtap and discards everything
 > read, because otherwise I get countless ICMP replies for an
 > unreachable port, and also every second or so gsmtap packet gets
 > dropped on the floor. 

I think then something is wrong.  We "solved" this problem years ago by having a built-in gsmtap listener in programs: See libosmocore "gsmtap_source_add_sink_fd()" and "gsmtap_source_add_sink()"

If log_target_create_gsmtap() is called with add_sink==true (which it is from logging_vty.c) then the GSMTAP packets are both originated and received by the program.  No additional tool should be required.

Also, even *if* you want an external command-line tool, then I would argue it shouldn't just print the "." but should actually print the log messages to stdout/stderr?

-- 
To view, visit https://gerrit.osmocom.org/6516
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85499af06bc5a0d757f6071779075e57bb435930
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list