This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: MSC_Tests: Set verdicts from inconc to fail ...................................................................... MSC_Tests: Set verdicts from inconc to fail Channels not being closed/cleared at the end of the test is a clear failure, so don't mark the test as inconc. Change-Id: Ie9188111da744f0aafaac02841d36a957bfc8d86 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 0627aa2..d50c571 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -110,7 +110,7 @@ /* altstep for the global guard timer */ private altstep as_Tguard() runs on BSC_ConnHdlr { [] g_Tguard.timeout { - setverdict(inconc, "Tguard timeout"); + setverdict(fail, "Tguard timeout"); self.stop; } } @@ -720,7 +720,7 @@ self.stop; } [] T.timeout { - setverdict(inconc, "Timeout waiting for ClearCommand"); + setverdict(fail, "Timeout waiting for ClearCommand"); self.stop; } } @@ -737,7 +737,7 @@ self.stop; } [] T.timeout { - setverdict(inconc, "Timeout waiting for SCCP Release"); + setverdict(fail, "Timeout waiting for SCCP Release"); self.stop; } } diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 0b3c6d5..7a42f05 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -528,7 +528,7 @@ [] GSUP.receive(tr_GSUP_UL_REQ(g_pars.imsi)) { setverdict(fail, "Unexpected GSUP UL REQ"); } - [] T.timeout { setverdict(inconc, "Timeout waiting for CM SERV REQ"); } + [] T.timeout { setverdict(fail, "Timeout waiting for CM SERV REQ"); } } f_expect_clear(); @@ -1035,7 +1035,7 @@ BSSAP.receive(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_IND); } [] T.timeout { - setverdict(inconc, "Timeout waiting for ClearCommand or SCCP Release"); + setverdict(fail, "Timeout waiting for ClearCommand or SCCP Release"); self.stop; } } @@ -1072,7 +1072,7 @@ } [] BSSAP.receive(tr_PDU_DTAP_MT(?)) { repeat; } [] T.timeout { - setverdict(inconc, "Timeout waiting for ClearCommand or SCCP Release"); + setverdict(fail, "Timeout waiting for ClearCommand or SCCP Release"); self.stop; } } -- To view, visit https://gerrit.osmocom.org/6492 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9188111da744f0aafaac02841d36a957bfc8d86 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder