[PATCH] libosmo-sccp[master]: SS7: return error on stream opening error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Feb 13 13:44:53 UTC 2018


Review at  https://gerrit.osmocom.org/6407

SS7: return error on stream opening error

Previously we've just logged error but continued as is.
Let's treat it as a error to let upper layers decide on it.

Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9
---
M src/osmo_ss7.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/07/6407/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 7f82f6e..bf5cf1d 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1251,6 +1251,7 @@
 		if (rc < 0) {
 			LOGSS7(asp->inst, LOGL_ERROR, "Unable to open stream"
 				" client for ASP %s\n", asp->cfg.name);
+			return -ENOSTR;
 		}
 		/* TODO: make this configurable and not implicit */
 		role = XUA_ASPFSM_ROLE_ASP;

-- 
To view, visit https://gerrit.osmocom.org/6407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ce55983b255b0b50fd5142d6ddf188dc8ee20b9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list