This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgcosmetic: No need for 'break' after 'return' This just makes the code longer with no added benefit. Change-Id: If689b8284a669021219eff0397c6e90570e2aaa4 --- M src/libmsc/a_iface.c M src/libmsc/a_iface_bssap.c 2 files changed, 0 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/34/6334/2 diff --git a/src/libmsc/a_iface.c b/src/libmsc/a_iface.c index 0e6c247..e24d3ad 100644 --- a/src/libmsc/a_iface.c +++ b/src/libmsc/a_iface.c @@ -245,31 +245,22 @@ switch (speech_ver) { case GSM48_BCAP_SV_FR: return GSM0808_PERM_FR1; - break; case GSM48_BCAP_SV_HR: return GSM0808_PERM_HR1; - break; case GSM48_BCAP_SV_EFR: return GSM0808_PERM_FR2; - break; case GSM48_BCAP_SV_AMR_F: return GSM0808_PERM_FR3; - break; case GSM48_BCAP_SV_AMR_H: return GSM0808_PERM_HR3; - break; case GSM48_BCAP_SV_AMR_OFW: return GSM0808_PERM_FR4; - break; case GSM48_BCAP_SV_AMR_OHW: return GSM0808_PERM_HR4; - break; case GSM48_BCAP_SV_AMR_FW: return GSM0808_PERM_FR5; - break; case GSM48_BCAP_SV_AMR_OH: return GSM0808_PERM_HR6; - break; } /* If nothing matches, tag the result as invalid */ diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c index 77a7779..809cb3a 100644 --- a/src/libmsc/a_iface_bssap.c +++ b/src/libmsc/a_iface_bssap.c @@ -633,31 +633,22 @@ switch (msg->l3h[0]) { case BSS_MAP_MSG_CLEAR_RQST: return bssmap_rx_clear_rqst(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_CLEAR_COMPLETE: return bssmap_rx_clear_complete(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_COMPLETE_LAYER_3: return bssmap_rx_l3_compl(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_CLASSMARK_UPDATE: return bssmap_rx_classmark_upd(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_CIPHER_MODE_COMPLETE: return bssmap_rx_ciph_compl(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_CIPHER_MODE_REJECT: return bssmap_rx_ciph_rej(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_ASSIGMENT_FAILURE: return bssmap_rx_ass_fail(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_SAPI_N_REJECT: return bssmap_rx_sapi_n_rej(scu, a_conn_info, msg); - break; case BSS_MAP_MSG_ASSIGMENT_COMPLETE: return bssmap_rx_ass_compl(scu, a_conn_info, msg); - break; default: LOGP(DMSC, LOGL_ERROR, "Unimplemented msg type: %s\n", gsm0808_bssmap_name(msg->l3h[0])); msgb_free(msg); @@ -708,10 +699,8 @@ case BSSAP_MSG_BSS_MANAGEMENT: msg->l3h = &msg->l2h[sizeof(struct bssmap_header)]; return rx_bssmap(scu, a_conn_info, msg); - break; case BSSAP_MSG_DTAP: return rx_dtap(scu, a_conn_info, msg); - break; default: LOGP(DMSC, LOGL_ERROR, "Unimplemented BSSAP msg type: %s\n", gsm0808_bssap_name(msg->l2h[0])); msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/6334 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If689b8284a669021219eff0397c6e90570e2aaa4 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder