[MERGED] gapk[master]: src/Makefile.am: fix osmo-gapk LDADD dependency

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 6 08:21:50 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: src/Makefile.am: fix osmo-gapk LDADD dependency
......................................................................


src/Makefile.am: fix osmo-gapk LDADD dependency

This change fixes parallel building problem, when osmo-gapk was
being compiled before its libosmogapk dependency:

  make[2]: *** No rule to make target '../src/libosmogapk.la',
               needed by 'osmo-gapk'.  Stop.
  make[2]: *** Waiting for unfinished jobs....

For some reason, automake ignores a dependency if the full
path is provided:

  $(top_builddir)/src/libosmogapk.la

while the relative path solves the problem:

  libosmogapk.la

Closes: OS#2907
Change-Id: I3fdd1731bd372bbb42fe57981e757386e8ede0f0
---
M src/Makefile.am
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Verified
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/Makefile.am b/src/Makefile.am
index 8efd165..50ffda4 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -93,5 +93,5 @@
 	$(NULL)
 
 osmo_gapk_LDADD = \
-	$(top_builddir)/src/libosmogapk.la \
+	libosmogapk.la \
 	$(NULL)

-- 
To view, visit https://gerrit.osmocom.org/6253
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fdd1731bd372bbb42fe57981e757386e8ede0f0
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list