osmocom-bb[master]: Import gprsdecode utility from SRLabs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue Feb 6 07:08:46 UTC 2018


Patch Set 6:

(3 comments)

https://gerrit.osmocom.org/#/c/5992/6//COMMIT_MSG
Commit Message:

Line 2: Author:     Max <msuraev at sysmocom.de>
> I'm not sure if we should attribute max as author in git, if it's code orig
Done


https://gerrit.osmocom.org/#/c/5992/6/src/host/gprsdecode/gprs.c
File src/host/gprsdecode/gprs.c:

Line 3:  * (C) 2017-2018 by Max <msuraev at sysmocom.de>
> this should be copyright by sysmocom - s.f.m.c. GmbH with an Author: Max, s
Done


https://gerrit.osmocom.org/#/c/5992/6/src/host/gprsdecode/rlcmac.h
File src/host/gprsdecode/rlcmac.h:

Line 29: 	uint8_t data[53];
> might be interesting to have some description about the rationale of those 
I wish I could do this, but I am not so good in GPRS for now.
This would be done in a separate commit, probably with some
more improvements...


-- 
To view, visit https://gerrit.osmocom.org/5992
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12234d37c66b83b8abd60f7511fa1d7837db1856
Gerrit-PatchSet: 6
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list