This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/6273 virtual: l1_if.c: Remove unneeded warning message Commit 5eb17e28acdd6fba22a1f2e60f4d55aaef18b47a added this warning when implementing the full function. However, other backends seem to be also passing the primitive from the stack to l1sap_up without any visible issues. Furthermore, according to the documentation of l1sap_up, it takes ownership of the msgb, but doesn't take ownserhip of the prim itself. Change-Id: I45fe40e3377eac999d1dac5356678195381d94ca --- M src/osmo-bts-virtual/l1_if.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/6273/1 diff --git a/src/osmo-bts-virtual/l1_if.c b/src/osmo-bts-virtual/l1_if.c index cb6d483..e7478a0 100644 --- a/src/osmo-bts-virtual/l1_if.c +++ b/src/osmo-bts-virtual/l1_if.c @@ -163,8 +163,7 @@ goto nomessage; } - /* forward primitive, forwarded msg will not be freed */ -#warning "we cannot just pass a l1sap primitive on the stack!!!" + /* forward primitive, lsap takes ownership of the msgb. */ l1sap_up(pinst->trx, &l1sap); DEBUGP(DL1P, "Message forwarded to layer 2.\n"); return; -- To view, visit https://gerrit.osmocom.org/6273 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45fe40e3377eac999d1dac5356678195381d94ca Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>