Change in osmo-sgsn[master]: Store GSN address in libosmocore struct

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Fri Dec 28 14:52:09 UTC 2018


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/12352 )

Change subject: Store GSN address in libosmocore struct
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h
File include/osmocom/sgsn/gtphub.h:

https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h@377
PS2, Line 377: 	struct osmo_gsn_address addr;
> You are breaking ABI here, length of struct is different. […]
But why would one want to have two representations of a GSN address? When to use which? If osmo_gsn_address is a superset why wouldn't we want to use it everywhere?



-- 
To view, visit https://gerrit.osmocom.org/12352
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a
Gerrit-Change-Number: 12352
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Fri, 28 Dec 2018 14:52:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181228/dc2eecef/attachment.htm>


More information about the gerrit-log mailing list