Change in libosmocore[master]: vty: Make TCP port configurable and introduce telnet_init_default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sat Dec 22 16:50:23 UTC 2018


Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/12321 )

Change subject: vty: Make TCP port configurable and introduce telnet_init_default
......................................................................


Patch Set 3:

> Patch Set 1: Code-Review-1
> 
> (4 comments)
> 
> I still would like to see a better commit description.

"better" is not very actionable. What do you think can/should be better in the commit description?


-- 
To view, visit https://gerrit.osmocom.org/12321
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5fb2faaf4311bd7284ee870526a6f87b7e260f3
Gerrit-Change-Number: 12321
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 22 Dec 2018 16:50:23 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181222/c85ef26d/attachment.htm>


More information about the gerrit-log mailing list