This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12388 ) Change subject: make sure early lchan act failure resets the lchan ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/12388/1/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/12388/1/include/osmocom/bsc/gsm_data.h@516 PS1, Line 516: struct gsm_lchan *re_use_mgw_endpoint_from_lchan; > While at it, it would be great if you could please document better some of these fields. […] yes, but in a separate patch. https://gerrit.osmocom.org/#/c/12388/1/src/osmo-bsc/lchan_fsm.c File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/#/c/12388/1/src/osmo-bsc/lchan_fsm.c@509 PS1, Line 509: struct mgwep_ci *use_mgwep_ci = lchan_use_mgw_endpoint_ci_bts(lchan); good catch below, this line here should have moved down ...... https://gerrit.osmocom.org/#/c/12388/1/src/osmo-bsc/lchan_fsm.c@536 PS1, Line 536: /* From lchan_reset(): > Where is lchan_reset() called? please provide that info in this line. […] reset happens when entering the UNUSED state, which is the whole point of this patch :) but ok -> follow up patch. https://gerrit.osmocom.org/#/c/12388/1/src/osmo-bsc/lchan_fsm.c@569 PS1, Line 569: use_mgwep_ci = lchan_use_mgw_endpoint_ci_bts(lchan); > where does this line come from? I don't see it in the previous block (previous commit file state <-) […] ......moved down here. nice catch! -- To view, visit https://gerrit.osmocom.org/12388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide665b10fa3f4583059c55346db8da833959e3cc Gerrit-Change-Number: 12388 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 21 Dec 2018 02:01:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181221/43e4666e/attachment.htm>