This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12385 ) Change subject: LOGPFSM*: guard against fi == NULL ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12385/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12385/1//COMMIT_MSG@9 PS1, Line 9: they should guard against a NULL > Any reasons why should we tolerate NULL? We have various places where an FSM instance is only allocated if something starts, like lchan->fi or assignment->fi etc. If we put some LOGPFSM() using that ->fi pointer that happens to still be NULL, it's more stable to log "NULL" instead of segfault straight away. So if anyone anywhere doesn't pay attention about an unpopulated ->fi, we introduce program crashes. This patch generally avoids those, and if someone cares enough they can fix the NULL logging later. -- To view, visit https://gerrit.osmocom.org/12385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eaf8b7e2cf1e450ae626cb2fc928862008f6233 Gerrit-Change-Number: 12385 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 20 Dec 2018 22:40:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181220/95674c81/attachment.htm>