Change in osmo-sgsn[master]: make gsup ipa name configurable in osmo-sgsn.cfg

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12243 )

Change subject: make gsup ipa name configurable in osmo-sgsn.cfg
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.osmocom.org/#/c/12243/5/src/gprs/sgsn_vty.c
File src/gprs/sgsn_vty.c:

https://gerrit.osmocom.org/#/c/12243/5/src/gprs/sgsn_vty.c@181
PS5, Line 181: ipa-name
Missing "gsup" prefix. Maybe rather place it together with other GSUP parameters?


https://gerrit.osmocom.org/#/c/12243/5/src/gprs/sgsn_vty.c@1084
PS5, Line 1084:       
Other DEFUNs are using a single tab here as far as I can see.


https://gerrit.osmocom.org/#/c/12243/5/src/gprs/sgsn_vty.c@1092
PS5, Line 1092: return CMD_WARNING;
Could we just warn user that this change has no effect until restart?
Or would it break anything at run-time?



-- 
To view, visit https://gerrit.osmocom.org/12243
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f65fed9f56b9718e8a9647e3f01dce69870c1f
Gerrit-Change-Number: 12243
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Dec 2018 15:07:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181220/1223ccb0/attachment.htm>