Change in osmo-msc[master]: libmsc/gsm_04_11.c: forward MO SMS messages over GSUP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu Dec 20 11:28:44 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11919 )

Change subject: libmsc/gsm_04_11.c: forward MO SMS messages over GSUP
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.osmocom.org/#/c/11919/2/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/#/c/11919/2/src/libmsc/gsm_04_11.c@674
PS2, Line 674: 
> Yep, I expected this question. The main idea is that some […]
I agree that if { } else { } would be better.
We shouldn't let code quality suffer just because code we write is supposed to be temporary.



-- 
To view, visit https://gerrit.osmocom.org/11919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d651fde3d608d02f275a74043dc42262aabb1b8
Gerrit-Change-Number: 11919
Gerrit-PatchSet: 8
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181220/0f257db4/attachment.htm>


More information about the gerrit-log mailing list