Change in libosmo-sccp[master]: fix ipa_asp_fsm down state transition

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/12364 )

Change subject: fix ipa_asp_fsm down state transition
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Being unfamiliar with the code helps to highlight things which makes review difficult :)

https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c
File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c@920
PS1, Line 920: {
So the only use of fi is to get *priv? Than better just pass struct ipa_asp_fsm_priv *iafp as parameter and let caller take care of fi-priv. This function have nothing to do with osmo_fsm_inst so it's better if this is immediately obvious when you look at type signature, which you're effectively changing compared to ipa_asp_fsm_cleanup() anyway.


https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c@939
PS1, Line 939: 	osmo_timer_del(&iafp->pong_timer);
I don't understand how it works if we bail out before reaching here. Does pong_timer kept forever? Or it's removed by some other code? Please double-check and clarify in a comment or commit message.


https://gerrit.osmocom.org/#/c/12364/1/src/xua_asp_fsm.c@1060
PS1, Line 1060: 	ipa_asp_fsm_del_route(fi);
I'd rather see ipa_asp_fsm_cleanup() moved in place of ipa_asp_fsm_del_route() instead of keeping it as this wrapper. If we ever have to change ipa_asp_fsm_del_route() in a way which requires updating its callees than this wrapper is unnecessary indirection which makes it less trivial than it should be. Even in this commit you've de-facto dropped unused cause parameter but because of this indirection it's unclear which parts of the code are affected.



-- 
To view, visit https://gerrit.osmocom.org/12364
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb8e7bd1c74a4b47080fe32ebe0161c503ead571
Gerrit-Change-Number: 12364
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:28:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181220/28be6ae8/attachment.htm>