This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12368 ) Change subject: abort assignment on Assignment Failure ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c File src/libmsc/msc_mgcp.c: https://gerrit.osmocom.org/#/c/12368/3/src/libmsc/msc_mgcp.c@1085 PS3, Line 1085: conn->fi->id); > Why not 'LOGPFSM(conn->fi, ... […] because then it would be clamped to another logging category. To reiterate, the LOGPFSM() was initially intended for logging the FSM state transitions, but using the FSM instance's context is super useful. So at some point I added LOGPFSML() to be able to modify the logging level. However, so far each FSM definition is fixed to one particular logging category, ran_conn is always DMM. Maybe we also need LOGPFSMSL(FI, SUBSYS, LEVEL, fmt, args)? The next best thing is to use the FSM instance's context as a string in a normal log statement. That omits the current FSM state, but otherwise logs everything else of interest. -- To view, visit https://gerrit.osmocom.org/12368 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I358cfbaf0f44f25148e8b9bafcb9257b1952b35a Gerrit-Change-Number: 12368 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Wed, 19 Dec 2018 22:29:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/2163443b/attachment.htm>