This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has uploaded this change for review. ( https://gerrit.osmocom.org/12375 Change subject: LCLS: don't encode incorrect values ...................................................................... LCLS: don't encode incorrect values Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59 --- M src/gsm/gsm0808.c 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/12375/1 diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index 69da57d..0f9e8df 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -335,8 +335,12 @@ * \returns callee-allocated msgb with BSSMAP LCLS NOTIFICATION */ struct msgb *gsm0808_create_lcls_conn_ctrl_ack(enum gsm0808_lcls_status status) { - struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, - "bssmap: LCLS CONN CTRL ACK"); + struct msgb *msg; + + if (status == GSM0808_LCLS_STS_NA) + return NULL; + + msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, "bssmap: LCLS CONN CTRL ACK"); if (!msg) return NULL; @@ -353,8 +357,12 @@ * \returns callee-allocated msgb with BSSMAP LCLS NOTIFICATION */ struct msgb *gsm0808_create_lcls_notification(enum gsm0808_lcls_status status, bool break_req) { - struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, - "bssmap: LCLS NOTIFICATION"); + struct msgb *msg; + + if (status == GSM0808_LCLS_STS_NA) + return NULL; + + msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, "bssmap: LCLS NOTIFICATION"); if (!msg) return NULL; -- To view, visit https://gerrit.osmocom.org/12375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9ac4bae75f5796e6e11346b8cb34d3897ae70b59 Gerrit-Change-Number: 12375 Gerrit-PatchSet: 1 Gerrit-Owner: Max <msuraev at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/79df6c80/attachment.htm>