Change in osmo-mgw[master]: mgcp_client_vty: fix missing talloc_free

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Dec 19 18:38:49 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12355 )

Change subject: mgcp_client_vty: fix missing talloc_free
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12355/2/src/libosmo-mgcp-client/mgcp_client_vty.c
File src/libosmo-mgcp-client/mgcp_client_vty.c:

https://gerrit.osmocom.org/#/c/12355/2/src/libosmo-mgcp-client/mgcp_client_vty.c@47
PS2, Line 47: 				   (char**)&global_mgcp_client_conf->local_addr,
> Probably, 'const char *' vs 'char *'?
yea the struct defines it as const, and that won't go with talloc.

It should have been a char[] from the start, but probably not worth the trouble to change that



-- 
To view, visit https://gerrit.osmocom.org/12355
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I331b3d53b5eb330b87d798f952077a043674d409
Gerrit-Change-Number: 12355
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/e54161b6/attachment.htm>


More information about the gerrit-log mailing list