Change in osmo-hlr[master]: gsupclient: introduce osmo_gsup_client_enc_send()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Dec 19 18:08:05 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11989 )

Change subject: gsupclient: introduce osmo_gsup_client_enc_send()
......................................................................


Patch Set 7: Code-Review+1

(3 comments)

if you like, fix the doc first

https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c
File src/gsupclient/gsup_client.c:

https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@366
PS4, Line 366:  * \returns 0 in case of success, otherwise -errno
> Ok.
osmo_gsup_client_{send,encode}() both return negative on error, and you're returning their rc, so this should also say "negative"


https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@381
PS4, Line 381: 	if (rc) {
> > to make reading code easier. […]
if (rc) is fine


https://gerrit.osmocom.org/#/c/11989/4/src/gsupclient/gsup_client.c@387
PS4, Line 387: 	if (rc) {
> And here too. It's a common practice to expect 0 and nothing else.
if (rc) is fine



-- 
To view, visit https://gerrit.osmocom.org/11989
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0589ff27933e9bca2bcf93b8259004935778db8f
Gerrit-Change-Number: 11989
Gerrit-PatchSet: 7
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 18:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/b530f812/attachment.htm>


More information about the gerrit-log mailing list