Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

[Stefan Sperling]

Hello Max, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/12349

to look at the new patch set (#3).

Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE
......................................................................

improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

The BSC may choose to omit the chosenEntryptionAlgorithm IE in
the CIPHER MODE COMPLETE command. When this happens, we used to
default to A5/1 and disregarded the list of ciphers which we
requested in the CIPHER MODE CMD. Fall back to the best cipher
instead of hard-coding a fallback to A5/1.

If the BSC does specify an algorithm, ensure that the chosen value
falls within the range allowed by GSM 04.08, and ensure that the
chosen value matches one of the values we sent in CIPHER MODE CMD.

Change-Id: I3260bee43cfe135ebfc33c13aee3c4ba43466c81
Related: OS#2872
---
M include/osmocom/msc/gsm_04_08.h
M src/libmsc/a_iface_bssap.c
M src/libmsc/gsm_04_08.c
3 files changed, 56 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/49/12349/3
-- 
To view, visit https://gerrit.osmocom.org/12349
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3260bee43cfe135ebfc33c13aee3c4ba43466c81
Gerrit-Change-Number: 12349
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <stsp at stsp.name>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181219/515d79e3/attachment.htm>