Change in osmo-msc[master]: msc_vty: also show IMEI and IMEISV

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Dec 18 17:42:34 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12343 )

Change subject: msc_vty: also show IMEI and IMEISV
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c
File src/libmsc/msc_vty.c:

https://gerrit.osmocom.org/#/c/12343/2/src/libmsc/msc_vty.c@642
PS2, Line 642: 	if (strlen(vsub->imei))
> Yeah that would be a better idiom but not critical from my point of view.
Not critical but better for performance reasons, and it only requires one line change, so I think it's fair I ask for it :)



-- 
To view, visit https://gerrit.osmocom.org/12343
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedd75dbb9850388ec1fedb984ed0b8bf4c62e780
Gerrit-Change-Number: 12343
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Tue, 18 Dec 2018 17:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181218/cd18ae6f/attachment.htm>


More information about the gerrit-log mailing list